Expose unified list_balances interface method
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
5 times, most recently
from
122fd00
to
d765fb6
Compare
tnull
changed the title
list_balance interface methodlist_balances interface method
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
from
d765fb6
to
8495bc7
Compare
|
Should be good for review. Will rebase #141 on top of this as |
wpaulino
reviewed
Feb 16, 2024
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
from
17a6c9f
to
1a893e7
Compare
This was referenced Feb 20, 2024
Merged
wpaulino
reviewed
Feb 20, 2024
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
from
49fd02b
to
7d88944
Compare
|
LGTM after squash |
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
from
7d88944
to
6883949
Compare
Squashed fixups and rebased to resolve minor conflicts. |
This was discussed upstream but reverted for now. The field is very confusing and misleading, and we can finally drop it now that we have a better `list_balances` interface.
tnull
force-pushed
the
2024-02-unified-balance-interface
branch
from
6883949
to
e809b23
Compare
|
Rebased to resolve minor conflicts (rustfmt). |
wpaulino
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212.